How to require a field only if some condition is true?

valdinei · February 9, 2023, 7:39pm

I have a field (let’s suppose it’s “prices”) that should only be required if other field (named “type”) is some value.
I saw that if some Input it’s not required, the package ignore when value is not provided, so add a validator in validator chain is useless. Also, if it’s required, the Input method will end the validation with an error before check if it’s really required.

How can I validate this case?

froschdesign · February 9, 2023, 7:44pm

Hello and welcome to our forums!

Do you mean laminas-inputfilter or the usage in form via laminas-form?

valdinei · February 9, 2023, 7:45pm

It’s laminas-inputfilter.

ALTAMASH80 · February 10, 2023, 2:44pm

Hi @valdinei,

The answer given in this post by @froschdesign might help you. Thanks!

valdinei · February 10, 2023, 2:53pm

Hi, @ALTAMASH80.

So, I know about the $context argument, but as I said in my post the validator that I would create and use the $context variable in isValid method won’t even be called by Input class (in this line 416).
The validation will fail in InputFilter isValid method (because the field is empty + not required) or it will fail in Input isValidmethod (because the field is empty + required), so will fail in both cases before my custom validator run.

The issue is not about condition with other field, is about be required in some conditions (what I think that it’s not possible with these packages).

Edit: in other words, I want to run the validator chain even if the value was not provided.

ALTAMASH80 · February 10, 2023, 3:29pm

Hi @valdinei,

If you think what you’re trying to achieve is not possible in Laminas Validators/Filters packages then you should file an issue in the Laminas Form package and contribute to making it better for others. Thanks!

williamgall · February 13, 2023, 12:03pm

before you validate your form in your controller you can test the value of the type field and it its the type that doesn’t require a price you can remove the validator from the price field prior to validating the posted data.

froschdesign · February 20, 2023, 2:27pm

Please don’t do this! The form or the input filter can and should include the entire handling.
If you cannot find another solution, you can, for example, always overwrite the isValid method and change the input filter based on the specified data.

If you do this in the controller then you will run in the following problems:

handling of the data is outsourced and independent from forms and input filters
copy and past of external logic is needed if you use the form or input filter in other places, like controller actions, request handlers, …
the unit tests for form or input filter can not cover the real scenarios / usage

froschdesign · February 20, 2023, 2:36pm

In some cases, the validation chain you define is never reached because the Laminas\InputFilter\Input::isValid() method produces a result before it:

github.com

laminas/laminas-inputfilter/blob/01c56c11904565b0f594c9cb745b5457a0e390eb/src/Input.php#L363-L400


      
          if (! $hasValue && $this->hasFallback()) {
              $this->setValue($this->getFallbackValue());
              return true;
          }
          
          if (! $hasValue && ! $required) {
              return true;
          }
          
          if (! $hasValue) { // required, but no value
              if ($this->errorMessage === null) {
                  $this->errorMessage = $this->prepareRequiredValidationFailureMessage();
              }
              return false;
          }
          
          if ($empty && ! $required && ! $continueIfEmpty) {
              return true;
          }

This file has been truncated. show original

If you run into this problem, the easiest option is to override the isValid method of your input filter. Or if you use laminas-form and specification of the input filter via array syntax, without separate class for the input filter, then overwrite the isValid of your form.

williamgall · February 20, 2023, 5:35pm

I realize there are cons to my approach but it solves the problem till someone like you can point us to a more elegant solution. Thank You

froschdesign · February 20, 2023, 7:55pm

Normalise and validate input – or other things – should not be spread over several layers. If you isolate it, it should work completely and correctly, then it can be easily reused and fully tested.
But this is not a problem specific of Laminas; it can be applied to any other framework.

froschdesign · February 20, 2023, 7:57pm

The following issue can be found in the issue tracker of laminas-inputfilter:

github.com/laminas/laminas-inputfilter

How use Callback validator when field is conditionally required?

opened 09:30PM - 31 Dec 19 UTC

weierophinney

Question

I have two fields and one of them is required if the value of the other is equal… to one condition. How can I do this? The "campaignFranchise" field is only required when the value of the "campaign" is equal to "franchise". <pre> 4 => [ 'required' => true, 'validators' => [ 0 => [ 'name' => NotEmpty::class, 'options' => [...], ], 1 => [ 'name' => StringLength::class, 'options' => [...], ], ], 'filters' => [...], 'name' => 'campaign', ], 5 => [ 'required' => true, 'validators' => [ 0 => [ 'name' => NotEmpty::class, 'options' => [ 'translatorenabled' => true, ], 'break_chain_on_failure' => true, ], 1 => [ 'name' => Callback::class, 'options' => [ 'callback' => [ CampaignFranchise::class, 'isValid', ], ], ], 2 => [ 'name' => StringLength::class, 'options' => [...], ], ], 'filters' => [...], 'name' => 'campaignFranchise', ], </pre> I try use "continueIfEmpty" and "allowEmpty" but how I don't have value and is required, the validation return false. https://github.com/zendframework/zend-inputfilter/blob/master/src/Input.php#L410-415 If the field is required false, the validation does not trigger. https://github.com/zendframework/zend-inputfilter/blob/master/src/BaseInputFilter.php#L251-L256 And if I use the callback validator in "campaign" field, the message error result display in wrong field. --- Originally posted by @vincequeiroz at https://github.com/zendframework/zend-inputfilter/issues/146

Topic		Replies	Views
Form Fieldset Validation Components & MVC laminas-form , laminas-mvc , laminas-validator	6	256	April 20, 2023
Date field validation Components & MVC laminas-form , laminas-validator	8	303	February 16, 2023
Laminas validator chain, it works as all the conditions must satisfied then pass, how to make it one condiction satisfied then pass? Components & MVC laminas-form	2	304	July 14, 2021
Why allow_empty is ineffective? Components & MVC laminas-form , laminas-inputfilter	1	491	September 1, 2022
Possible Bug validating non-text input Components & MVC laminas-form , laminas-inputfilter	14	234	August 4, 2023

How to require a field only if some condition is true?

Related Topics